Skip to content

Commit

Permalink
Clarify log message for machine-controller isDeleteAllowed (kubernete…
Browse files Browse the repository at this point in the history
…s-sigs#905)

Users have noted that this log message is confusing and
does not lead to a clear path forward when deleting this
machine.

This commit makes it clear that the machine will not be
deleted.
  • Loading branch information
michaelgugino authored and detiber committed May 2, 2019
1 parent 91946e0 commit ba18c58
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/controller/machine/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ func (r *ReconcileMachine) Reconcile(request reconcile.Request) (reconcile.Resul
}

if !r.isDeleteAllowed(m) {
klog.Infof("Skipping reconciling of machine %q", name)
klog.Infof("Deleting machine hosting this controller is not allowed. Skipping reconciliation of machine %q", name)
return reconcile.Result{}, nil
}

Expand Down

0 comments on commit ba18c58

Please sign in to comment.