Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update abiParser.ts to work with foundry / forge output + Tests #624

Merged
merged 2 commits into from
Mar 6, 2022

Conversation

alvrs
Copy link
Contributor

@alvrs alvrs commented Feb 21, 2022

Adds tests to @joeandrews' PR (#618) and applies his change.

From @joeandrews' PR:
Forge / Foundry structures ABI's as below. This change makes the ABI parser compatible with the output from forge.

{
  "abi": [],
  "bytecode": {
    "object": "0x60566037600b82828239805160001a607314602a57634e487b7160e01b600052600060045260246000fd5b30600052607381538281f3fe73000000000000000000000000000000000000000030146080604052600080fdfea26469706673582212205bf70e5aa6eb164145ba1ab154b06c77bba3192b4507a03c711393334ab8aafb64736f6c634300080a0033",
    "sourceMap": "153:195:3:-:0;;;;;;;;;;;;;;;-1:-1:-1;;;153:195:3;;;;;;;;;;;;;;;;;",
    "linkReferences": {}
  },
  "deployed_bytecode": {
    "object": "0x73000000000000000000000000000000000000000030146080604052600080fdfea26469706673582212205bf70e5aa6eb164145ba1ab154b06c77bba3192b4507a03c711393334ab8aafb64736f6c634300080a0033",
    "sourceMap": "153:195:3:-:0;;;;;;;;",
    "linkReferences": {}
  }
}

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2022

🦋 Changeset detected

Latest commit: 3d56970

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
typechain Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alvrs alvrs changed the title Update abiParser.ts to work with foundry / forge output Update abiParser.ts to work with foundry / forge output + Tests Feb 21, 2022
@andrewwhitely
Copy link

@krzkaczor , i saw your comment on #618. have you had a chance to take a look at this one?

@krzkaczor krzkaczor merged commit 7e7bbed into dethcrypto:master Mar 6, 2022
@krzkaczor
Copy link
Member

krzkaczor commented Mar 6, 2022

@alvrs Thanks for working on this! I'll make a quick release in a sec as the next one will be a major one.

@krzkaczor
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants