Add KingOfTheHill contract with struct, error and event #514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new contract that's quite short but it has a little bit of everything. We can use it to test TypeChain's behaviour on Solidity
struct
s anderror
s.Part of #474 I guess? Treat this PR as a point to discuss instead of a change I wanna make to the code.
Idea: We already emit some runtime for factories. Should we use the information about errors from the ABI to emit type guards for errors?
The following ABI
could become something like
(As a side note, we'd need to fiddle with "ethers" dependency a bit, because we currently encounter ethers-io/ethers.js#1493)