Test contracts compiled with many Solidity versions and handle reserved words #501
Conversation
🦋 Changeset detectedLatest commit: 0472e11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
.eslintrc.js
Outdated
| @@ -12,7 +12,7 @@ module.exports = { | |||
| }, | |||
| rules: { | |||
| // this gets inlined into a package eslint, so it means: use current package's package.info or the one at the project root | |||
| 'import/no-extraneous-dependencies': ['error', { packageDir: ['./', __dirname] }], | |||
| 'import/no-extraneous-dependencies': ['error', { packageDir: ['./', __dirname], }], | |||
There was a problem hiding this comment.
nit: it would be best to ensure formatting in this file via prettier
There was a problem hiding this comment.
Nice spot. I don't remember changing this to be fair, I expected it to be a result of lint:fix.
|
It's missing changesets. You can try a minor change in TC core and we see if changeset properly changes peer dependency on targets (now ethers-v5 will require at least |
It seems that regardless if we bump |
I decided #497 is a good reason to test with multiple Soliditiy versions, so this PR aims to solve both the crash on reserved words and address #474.