chore: apply react strict mode and upgrade to React 17 [DET-5325] #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkang1
commented
Apr 26, 2021
hkang1
commented
Apr 26, 2021
hkang1
force-pushed
the
5325-react-strict-mode
branch
from
9908322 to
ef4002e
Compare
hkang1
changed the title
hkang1
commented
Apr 26, 2021
hkang1
requested review from
apizzini and
hamidzr
and removed request for
apizzini
apizzini
reviewed
Apr 27, 2021
apizzini
reviewed
Apr 27, 2021
|
This is looking good aside for the logviewer issue, we should probably consider landing this after the release just so that we can have people play around with the WebUI for 2 weeks before releasing it. |
👍 Yeah not looking to rush this one, because issues probably will popup up over time as it's a major upgrade. |
added 5 commits
April 27, 2021 13:21
hkang1
force-pushed
the
5325-react-strict-mode
branch
from
57e6e50 to
c9d668c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
React Strict Modeis going to help us migrate toReact v17.React Strict Modeand fix all errors and warnings.React Strict Mode Reference
Test Plan
npm startand check to make sure all the pages still worknpm run storybookand make sure it runs without errorsnpm run build-storybookand make sure it runs without errorsCommentary (optional)
Checklist
docs/release-notes/.See Release Note for details.