Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set max slots and checkpoint gc policy should comply with config policies #10140

Merged
merged 4 commits into from
Oct 31, 2024

remove transaction and return earlier when possible

ae4a0c6
Select commit
Loading
Failed to load commit list.
Merged

fix: set max slots and checkpoint gc policy should comply with config policies #10140

remove transaction and return earlier when possible
ae4a0c6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 31, 2024 in 1s

54.77% (+0.06%) compared to 782f7a0

View this Pull Request on Codecov

54.77% (+0.06%) compared to 782f7a0

Details

Codecov Report

Attention: Patch coverage is 88.88889% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.77%. Comparing base (782f7a0) to head (ae4a0c6).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...ternal/configpolicy/postgres_task_config_policy.go 86.36% 3 Missing ⚠️
master/internal/api_experiment.go 92.59% 2 Missing ⚠️
master/internal/configpolicy/utils.go 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10140      +/-   ##
==========================================
+ Coverage   54.71%   54.77%   +0.06%     
==========================================
  Files        1266     1266              
  Lines      159970   159988      +18     
  Branches     3662     3662              
==========================================
+ Hits        87525    87635     +110     
+ Misses      72312    72220      -92     
  Partials      133      133
Files with missing lines Coverage Δ
master/internal/experiment.go 35.93% <100.00%> (+2.15%) ⬆️
master/internal/api_experiment.go 61.23% <92.59%> (+4.31%) ⬆️
master/internal/configpolicy/utils.go 73.20% <80.00%> (-0.85%) ⬇️
...ternal/configpolicy/postgres_task_config_policy.go 90.12% <86.36%> (-1.02%) ⬇️

... and 2 files with indirect coverage changes

View more details on Codecov