feature: new component for sub account UI #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Sep 20, 2023
jackson-dean
force-pushed
the
09-20-feature_new_component_for_sub_account_UI
branch
from
c33b8df to
4dfabd2
Compare
jackson-dean
force-pushed
the
09-20-fix_fix_broken_avatar_directive
branch
from
67c2635 to
5b2951b
Compare
jackson-dean
force-pushed
the
09-20-feature_new_component_for_sub_account_UI
branch
from
4dfabd2 to
8501060
Compare
jackson-dean
force-pushed
the
09-20-fix_fix_broken_avatar_directive
branch
from
5b2951b to
3214590
Compare
jackson-dean
force-pushed
the
09-20-feature_new_component_for_sub_account_UI
branch
from
8501060 to
8043ab7
Compare
lazynina
approved these changes
Sep 20, 2023
jackson-dean
force-pushed
the
09-20-fix_fix_broken_avatar_directive
branch
from
3214590 to
4221a2b
Compare
jackson-dean
force-pushed
the
09-20-feature_new_component_for_sub_account_UI
branch
from
8043ab7 to
b5e020c
Compare
jackson-dean
force-pushed
the
09-20-fix_fix_broken_avatar_directive
branch
from
4221a2b to
e4e8c85
Compare
jackson-dean
force-pushed
the
09-20-feature_new_component_for_sub_account_UI
branch
from
b5e020c to
509b6b3
Compare
jackson-dean
force-pushed
the
09-20-fix_fix_broken_avatar_directive
branch
from
e4e8c85 to
6fef826
Compare
jackson-dean
force-pushed
the
09-20-feature_new_component_for_sub_account_UI
branch
from
509b6b3 to
ab7aea1
Compare
jackson-dean
force-pushed
the
09-20-fix_fix_broken_avatar_directive
branch
from
6fef826 to
6384f1b
Compare
jackson-dean
force-pushed
the
09-20-feature_new_component_for_sub_account_UI
branch
from
ab7aea1 to
90286f5
Compare
jackson-dean
force-pushed
the
09-20-fix_fix_broken_avatar_directive
branch
from
6384f1b to
d41e475
Compare
jackson-dean
force-pushed
the
09-20-feature_new_component_for_sub_account_UI
branch
from
90286f5 to
b9294b4
Compare
jackson-dean
force-pushed
the
09-20-fix_fix_broken_avatar_directive
branch
from
d41e475 to
50978bd
Compare
jackson-dean
force-pushed
the
09-20-feature_new_component_for_sub_account_UI
branch
from
b9294b4 to
2525f27
Compare
Base automatically changed from
09-20-fix_fix_broken_avatar_directive
to
09-20-refactor_update_account_service_to_support_sub_accounts
September 22, 2023 04:42
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
from
d30fa1c to
14e26d9
Compare
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
from
14e26d9 to
656702e
Compare
jackson-dean
force-pushed
the
09-20-feature_new_component_for_sub_account_UI
branch
from
0c0596c to
ca676f9
Compare
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
from
656702e to
5ea24e3
Compare
jackson-dean
force-pushed
the
09-20-feature_new_component_for_sub_account_UI
branch
from
ca676f9 to
ba80637
Compare
This was referenced Sep 22, 2023
Merged
* feature: add feature flag guard for new account select component * feature: backup seed component (#269) * feature: backup seed component * feature: add balance to account selector UI (#270) * feature: add balance to account selector UI * migrate swal to mat dialog (#273) * migrate swal to mat dialog * update button styles (#277) * update button styles * review feedback and bug fixes (#279)
jackson-dean
merged commit 25b37ce
into
09-20-refactor_update_account_service_to_support_sub_accounts
jackson-dean
deleted the
09-20-feature_new_component_for_sub_account_UI
branch
jackson-dean
added a commit
that referenced
this pull request
Sep 25, 2023
* feature: new component for sub account UI * feature: add feature flag guard for new account select component (#268) * feature: add feature flag guard for new account select component * feature: backup seed component (#269) * feature: backup seed component * feature: add balance to account selector UI (#270) * feature: add balance to account selector UI * migrate swal to mat dialog (#273) * migrate swal to mat dialog * update button styles (#277) * update button styles * review feedback and bug fixes (#279)
jackson-dean
added a commit
that referenced
this pull request
Sep 25, 2023
* feature: new component for sub account UI * feature: add feature flag guard for new account select component (#268) * feature: add feature flag guard for new account select component * feature: backup seed component (#269) * feature: backup seed component * feature: add balance to account selector UI (#270) * feature: add balance to account selector UI * migrate swal to mat dialog (#273) * migrate swal to mat dialog * update button styles (#277) * update button styles * review feedback and bug fixes (#279)
lazynina
added a commit
that referenced
this pull request
Nov 26, 2023
* refactor: update account service to support sub accounts * feature: new component for sub account UI (#266) * feature: new component for sub account UI * feature: add feature flag guard for new account select component (#268) * feature: add feature flag guard for new account select component * feature: backup seed component (#269) * feature: backup seed component * feature: add balance to account selector UI (#270) * feature: add balance to account selector UI * migrate swal to mat dialog (#273) * migrate swal to mat dialog * update button styles (#277) * update button styles * review feedback and bug fixes (#279) * Cleanup UI for multiple account mgmt (#280) * cleanup UI for multiple accout mgmt * run prettier * fix margin on metamask account * formatting * fix mobile * fix scrolling on overlay --------- Co-authored-by: Lazy Nina <> * auto, not scroll for overflow-y on overlay * fix sub account key generation (#281) * update cookie options in put and update logic for mustUseStorageAccess (#286) * update cookie options in put and update logic for mustUseStorageAccess * format * fix sameSite none * run format * add testnet verify-captcha to caddyfile * fix affiliateAddress for heroswap iframe in identity (#287) Co-authored-by: Lazy Nina <> --------- Co-authored-by: Lazy Nina <> --------- Co-authored-by: Ed Moss <[email protected]> Co-authored-by: Lazy Nina <> Co-authored-by: Lazy Nina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new component for displaying subaccounts. This will
replace the original account selector. This PR simply implements
the component but does not replace the old one in the UI yet.