Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Infura API to support Buy With ETH #484

Merged
merged 8 commits into from
Oct 18, 2021
Merged

Use Infura API to support Buy With ETH #484

merged 8 commits into from
Oct 18, 2021

Conversation

lazynina
Copy link
Member

No description provided.

remove unused GetEthBalance endpoint

save progress on new buy with eth

hold current changes

save current progress

hold current changes

move RPC requests to backend and fix transaction construction/signing
@lazynina lazynina requested a review from a team as a code owner October 15, 2021 01:58
Copy link
Contributor

@maebeam maebeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small nits! Looks great!

src/app/identity.service.ts Outdated Show resolved Hide resolved
@lazynina lazynina merged commit 03ed433 into main Oct 18, 2021
@lazynina lazynina deleted the ln/eth-v2 branch October 18, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants