Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book.ts theme #266

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

omicreativedev
Copy link
Contributor

📖 Book Theme is an eReader style alternative light theme that's inspired by Kindle and Opera reader mode designed to reduce eye strain without the "wired" effect of dark mode or blue light. The antique and sepia tones also help remedy glare and screen contrast in natural daylight and strong backlight. Book Theme might be nice when accessing Bitclout on tablet devices, iPads, etc.

book
book2
book3
book4

@omicreativedev omicreativedev requested a review from a team as a code owner July 11, 2021 02:18
@ItsAditya-xyz
Copy link
Contributor

How many themes we will have?
@teambrixmusic : Yes!

Greay work by the way!

@omicreativedev
Copy link
Contributor Author

@AdityaChaudhary0005 I closed the Repo for the Mars theme because it looks too different on different devices.

I imagine there would be a dozen or so themes covering the scope of user preferences and a few playful ones.

Another playful one I think users are looking for is Matrix. I've literally seen dozens of requests for it.

Beyond this one I won't be adding more as to leave room for others to add.

Most devices have light mode, dark mode and reader mode at least.

Studies have shown most people's favorite colors are blue, red, purple/pink, and green. It's also been shown that Blues on white result in the most user retention, hence why Facebook, Twitter, Linkedin (and even Git) default to white/blue. A whopping 70% of Kindle readers use Antique/Reader mode.

As for # of themes, I think we should at LEAST cover all common need basis:

  • Light (blue on white like facebook- done)
  • Dark (coder mode)
  • Read (this one, or antique)
  • Blue Dark (icy- done)
  • Blue Light (not done)
  • Green (we have greenish done)
  • Purple/Pink (cake done)
  • Red (rejected, need a new one)
    Fun
  • Matrix (not done)
  • Guild (legend done)

Might be worth a CIP to discuss.

main-qimg-e4b0ee84179351235a6098b4143cf5aa

@tijno
Copy link
Contributor

tijno commented Jul 11, 2021

Maybe rather then adding more themes - submit a CIP proposal for the themes we need ? Get that agreed - then can just put tasks on the kanban for each one still required?

@brootle
Copy link
Contributor

brootle commented Jul 11, 2021

Maybe rather then adding more themes - submit a CIP proposal for the themes we need ? Get that agreed - then can just put tasks on the kanban for each one still required?

People want to contribute to open source project, can't blame them for that. There are only 4 themes at Bitclout now, some open source projects have over 100!

@omicreativedev
Copy link
Contributor Author

I'm open to using CIPs for themes. However, I didn't want to burden CIPs as they're technically a small change. But I will CIP if they should be CIP'd LOL!

@ItsAditya-xyz
Copy link
Contributor

@brootle which open source project has 100 themes? 😅

I am not counting extensions (ex VS Code)

@brootle
Copy link
Contributor

brootle commented Jul 12, 2021

@brootle which open source project has 100 themes? 😅

I am not counting extensions (ex VS Code)

So VS Code used by 90% of developer can have 100+ themes, but Bitclout can't?

Have you heard about ATOM? It already has over 3,000 themes, go check it out https://atom.io/themes

I made a theme not because I want to win some monies, but because I want other devs like me to save their eyes and have something similar to Visual Studio Code default dark theme. I am pretty sure Visual Studio Code devs spent hours on research to make perfect color balance, Bitclout users deserve the best too!

@tijno
Copy link
Contributor

tijno commented Jul 12, 2021

@brootle i just think this decision / discussion is better placed here:

deso-protocol/dips#44

@teambrixmusic I think getting clarity on this as an example would be good.

Right now i dont think it falls under small change - but @lazynina or @maebeam might think otherwise.

So probably best to continue in deso-protocol/dips#44

@brootle
Copy link
Contributor

brootle commented Jul 12, 2021

I would say whatever Themes were suggested before now, must be reviewed and merged or rejected. And after that Bitlout devs can make some announcement regarding new themes PR.

Do we have high contrast dark theme? Yes. Do we have low contrast dark them? No. That's this simple.

@omicreativedev
Copy link
Contributor Author

omicreativedev commented Jul 13, 2021

@AdityaChaudhary0005

@brootle which open source project has 100 themes? 😅

I am not counting extensions (ex VS Code)

  • Wordpress
  • Joomla
  • Drupal
  • Megento
  • Textpatten
  • Typo3
  • Prestashop
  • Woocommerce
    and hundreds more

And non-open source too: blogger, shopify, wix, you name it.

Nodes are going to style themselves anyway.
I guess this is just about what we provide out the box by default to new frontend & node users- and what options we give the audience (that have no control) for user experience.

@omicreativedev
Copy link
Contributor Author

Will resolve conflicts after modals are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants