Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update inputs when adding node source to extra data #281

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update inputs when adding node source to extra data #281

wants to merge 4 commits into from

Conversation

superzordon
Copy link
Contributor

Closes #279

@superzordon superzordon requested a review from a team as a code owner January 20, 2022 01:31
maebeam
maebeam suggested changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@maebeam maebeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good idea, would prefer to change the method signature for all of these methods to add ExtraData param

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maebeam maebeam maebeam requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using NodeSource triggers RuleErrorTxnFeeBelowNetworkMinimum error
2 participants
@superzordon @maebeam