-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IBC profiles feature #412
Conversation
@dadamu If you think it would be better, I guess we can use Bech32 without any problem. I used the hex representation to make it chain-independent, but if we provide the Also, I would avoid putting the |
@RiccardoM I got it, the cross-chain and inter-chain links are associated with Profile directly, not account. So desmos address is not needed in |
Hey @dadamu, since this PR got quite big (more than 100 files to be checked), I think we should split it into multiple ones, each one with its review process. To do this, what I would ask you to do is the following:
At each PR me and @bragaz will review it and once everything is done, merge it into the destination branch. The overall process will be the following:
Ideally, all the PRs should be made towards a new branch called This way we will be able to review all the things faster and give you a more rapid feedback. If all of this is clear, please start with creating the branches and close this PR. |
Description
This PR implement #192, creating cross-chain link by IBC protocol and inter-chain link by message.
IBC profiles module features:
IBC feature in profiles module:
Checklist
CHANGELOG.md
file.Files changed
in the Github PR explorer.