Fix design token heading levels #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dtcg-tr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
drwpow
commented
Oct 24, 2024
| @@ -178,5 +178,3 @@ Tool vendors are encouraged to publicly share specifications of their extension | |||
| <p class="ednote" title="Extensions section"> | |||
| The extensions section is not limited to vendors. All token users can add additional data in this section for their own purposes. | |||
| </p> | |||
|
|
|||
| ## More token properties TBC | |||
There was a problem hiding this comment.
Opinionated: I just removed this; other properties can be added here as normal revisions to the spec
c1rrus
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes an unintentional heading level issue under “Design token”
Before
Section 5.2 seems to suggest that the following headings are underneath it (which would mirror Groups):
After
Section 5.2 makes more sense with sub-headings (and makes Tokens and Groups consistent)