Chore: Upgrade Node to v22, update deps #242
Conversation
✅ Deploy Preview for dtcg-tr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
drwpow
force-pushed
the
drwpow/upgrade-node
branch
from
c71f1dd to
08bf425
Compare
| with: | ||
| path: ~/.npm | ||
| key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-node- | ||
| - uses: actions/setup-node@v3 | ||
| with: { node-version: 16, cache: npm } |
There was a problem hiding this comment.
These days it’s generally safe to omit the Node version. Not only do major versions not break as often for most users anymore (unless you’re using bleeding-edge/experimental features), GitHub Actions also is pretty slow/cautious in changing the default. They’ll only use stable versions (even numbers in Node’s numbering system), and they’ll always wait several patches to make sure it’s safe.
Just using the latest Node version is not only more secure; it also tends to get faster with V8 updates.
drwpow
changed the title
|
I just updated the Netlify Site configuration to use Node v20. Node v22 should work too, but isn't fully supported. |
|
Looks like Chrome isn't available anymore – can you look into it? |
Sorry; what do you mean by Chrome not being available? |
|
Chrome must have been available in the old build image (see error logs), and isn't available with the Node 22 build image. I believe it's necessary for ReSpec to build. |
drwpow
force-pushed
the
drwpow/upgrade-node
branch
from
ea7e76c to
e258c8e
Compare
Just added a setup step for Puppeteer in Netlify. I think Netlify caches this well as it was pretty instant. |
drwpow
force-pushed
the
drwpow/upgrade-node
branch
from
e258c8e to
2777c5a
Compare
| @@ -1,4 +1,4 @@ | |||
| <!DOCTYPE html> | |||
| <!doctype html> | |||
There was a problem hiding this comment.
Just Prettier autoformatting in latest version
Also that’s fine! Node v20 is fine. I only updated to v22 because it’s been out for a while, it’s the latest stable version, and will be replacing v20 as the new active version in only a couple months. But it’s all fine, as long as we’re upgraded off an EOL version 😅 |
SHA: 729cbd8 Reason: push, by kaelig Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 729cbd8 Reason: push, by kaelig Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 729cbd8 Reason: push, by kaelig Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Changes
16→22. Node 16 is EOL. Welcome to the future 😎Reviewing