Skip to content

Commit

Permalink
PR Feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
drwpow committed Oct 24, 2024
1 parent 67ab90a commit f95cc4d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
7 changes: 5 additions & 2 deletions technical-reports/format/composite-types.md
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,10 @@ Represents a border style. The `$type` property MUST be set to the string `borde
"unit": "px"
},
"style": {
"dashArray": [{ "value": 0.5, "unit": "rem" }, "0.25rem"],
"dashArray": [
{ "value": 0.5, "unit": "rem" },
{ "value": 0.25, "unit": "rem" }
],
"lineCap": "round"
}
}
Expand Down Expand Up @@ -268,7 +271,7 @@ Represents a animated transition between two states. The `$type` property MUST b
"$type": "transition",
"$value": {
"duration": { "value": 200, "unit": "ms" },
"delay": { "value": 0 },
"delay": { "value": 0, "unit": "ms" },
"timingFunction": [0.5, 0, 1, 1]
}
}
Expand Down
9 changes: 4 additions & 5 deletions technical-reports/format/types.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,15 +174,15 @@ For example:

```json
{
"Duration-100": {
"Duration-Quick": {
"$value": {
"value": 100,
"unit": "ms"
},
"$type": "duration"
},
"Duration-200": {
"$value": { "value": 200 },
"Duration-Long": {
"$value": { "value": 1.5, "unit": "s" },
"$type": "duration"
}
}
Expand All @@ -192,8 +192,7 @@ For example:

### Validation

- `$value.unit` may only be `"ms"`, `"s"`, or omitted (`"ms"`)
- `$value.unit`, if omitted, is parsed as if it’s `"ms"`
- `$value.unit` may only be `"ms"` or `"s"`

## Cubic Bézier

Expand Down

0 comments on commit f95cc4d

Please sign in to comment.