-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI binary installation #3
Conversation
bd1a2ba
to
4b313b9
Compare
Hmm, looks like we can't yet ship multiple targets with maturin, but that should be something we can do soon. Let me see if we can find a workaround. |
One workaround would be to write a python wrapper for the rust CLI :/. Not ideal. Let me see how hard it would be to add multiple targets in maturin. |
Yeah, the idea is creating a bin for deploy and python bindings for test. I don't think we need both today. |
In that case, I think it makes sense to disable this test for now until the upstream change in maturin to support multiple build targets is merged. What do you think? |
4b313b9
to
91401c8
Compare
91401c8
to
bbb5561
Compare
Build issues on macos look like they're upstream: PyO3/maturin#1080 |
Let's disable macos and leave a reference to this issue as a comment? |
@peytondmurray let's try PyO3/maturin#1080 (comment) first? |
@mlucool Looks like there's an issue deeper in |
Yeah, let's drop osx for now and cross-link to the issue |
This PR adds a configuration setting to install the rust nbstripout-fast CLI to the python binary directory, so that users can easily launch the CLI after installing.