Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jupyterlab 4 #1

Merged
merged 1 commit into from
May 17, 2023

Conversation

peytondmurray
Copy link
Collaborator

@peytondmurray peytondmurray commented May 10, 2023

This PR updates this extension to jupyterlab 4. Given that this relies on registering an ipython magic, and given that there's not much to the frontend, there wasn't much to change here.

With jupyterlab==4.0.0rc1 everything seemed to work just fine when I loaded the extension (%load_ext jupyterlab_notify) and then ran

%%notify
import time
time.sleep(1)

@mlucool I bumped the patch version - are you okay with this or should I bump the minor (or major) version instead?

@peytondmurray peytondmurray changed the title Upgrade to jupyterlab 4 [WIP] Upgrade to jupyterlab 4 May 10, 2023
@peytondmurray peytondmurray changed the title [WIP] Upgrade to jupyterlab 4 Upgrade to jupyterlab 4 May 10, 2023
@peytondmurray peytondmurray marked this pull request as ready for review May 10, 2023 21:52
@mlucool
Copy link
Member

mlucool commented May 10, 2023

This would be a major version as if you upgraded and were on [email protected] I think it would break

@singharpit94 singharpit94 self-requested a review May 12, 2023 03:47
@singharpit94
Copy link

Tested that with jupyterlab4, things are working as expected, post test passing and version bump, we can merge.

@peytondmurray
Copy link
Collaborator Author

@singharpit94 Looks good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants