Skip to content

Commit

Permalink
Fix pre run cell event with ipython 8.18.x (#2)
Browse files Browse the repository at this point in the history
* Fix pre run cell event with ipython 8.18.x

* Bump to version 2.0.1

* Fix lint:

* Add release date

---------

Co-authored-by: Divyansh Choudhary <[email protected]>
  • Loading branch information
divyansshhh and Divyansh Choudhary authored Jan 16, 2024
1 parent c8e03b4 commit c62ffe3
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
## [2.0.1](https://github.com/deshaw/jupyterlab-notify/compare/v2.0.1...v2.0.0) (2024-01-16)

## Fixed

- Fix the pre run cell hook to be compatible with ipython 8.18.x+

## [2.0.0](https://github.com/deshaw/jupyterlab-notify/compare/v2.0.0...v1.0.0) (2023-05-17)

## Changed

- Upgrade to jupyterlab4

## [1.0.0](https://github.com/deshaw/jupyterlab-notify/compare/v1.0.0...v1.0.0) (2021-07-12)

### Added
Expand Down
2 changes: 1 addition & 1 deletion jupyterlab_notify/magics.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def notify_all(self, line):
if self._post_run_cell not in ip.events.callbacks["post_run_cell"]:
ip.events.register("post_run_cell", self._post_run_cell)

def _pre_run_cell(self):
def _pre_run_cell(self, info):
self.run_start_time = time.time()

def _post_run_cell(self, exec_result):
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "jupyterlab-notify",
"version": "2.0.0",
"version": "2.0.1",
"description": "JupyterLab extension to notify cell completion",
"keywords": [
"jupyter",
Expand Down

0 comments on commit c62ffe3

Please sign in to comment.