feat: Country Codes package #876
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit e4144ee.
☁️ Nx Cloud last updated this comment at |
|
@nirgur Since the console-app consumes this directly from WCUI, I think it'll be better to separate it instead of chaining it down through flow-components and the dynamic module, so we can consume only types from the dynamic module, and not content. I don't think this content is going to be versioned; and rather - we want to support updates to this list throughout all versions. WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes <link_to_github_issue>
Description
Currently, Phone Country Codes are consumed by the ConsoleApp from the Phone Component.
As part of the Components Versioning effort, we want to separate the content consumption from the component, as well as create a single source of truth of our country code list.
Must