Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Actually store user-provided prefix path #589

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

CommandMC
Copy link
Contributor

@CommandMC CommandMC commented Aug 10, 2023

On non-Windows, auth's --import flag prompts the user for a Wine prefix to import the login data from. The provided path is stored inside wine_pfx and... never used again. Because of that, egl_wine_pfx will always be None when reaching the below try block & the os.path.join in read_registry will throw an exception
I assume this was meant to assign to egl_wine_pfx directly

This was assigning to a local variable, only ever used in the `if` block
@loathingKernel
Copy link
Contributor

I assume this was meant to assign to egl_wine_pfx directly

According to the reply here I would say you are correct.

@derrod
Copy link
Owner

derrod commented Aug 10, 2023

Let's merge it before I forget about it again.

@derrod derrod merged commit bd2e7ca into derrod:master Aug 10, 2023
4 checks passed
@CommandMC CommandMC deleted the fix/auth-import-prefix branch August 10, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants