Use symfony/cache to convert doctrine/cache to PSR-6 and back #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
commented
Dec 3, 2019
| @@ -43,9 +47,12 @@ public function __construct($lifetime = 0, ?string $cacheKey = null, ?object $re | |||
| if ($resultCache instanceof Cache) { | |||
| @trigger_error(sprintf('Using an instance of %s as result cache is deprecated. Please provide a PSR-6 cache instead.', Cache::class), E_USER_DEPRECATED); | |||
|
|
|||
| $resultCache = new DoctrineCachePool($resultCache); | |||
| $resultCache = new DoctrineAdapter($resultCache); | |||
| $this->resultCacheDriver = $resultCache; | |||
There was a problem hiding this comment.
Since we can't unwrap a DoctrineAdapter, we store a doctrine/cache in a separate property for later returning.
| @@ -43,9 +47,12 @@ public function __construct($lifetime = 0, ?string $cacheKey = null, ?object $re | |||
| if ($resultCache instanceof Cache) { | |||
| @trigger_error(sprintf('Using an instance of %s as result cache is deprecated. Please provide a PSR-6 cache instead.', Cache::class), E_USER_DEPRECATED); | |||
|
|
|||
| $resultCache = new DoctrineCachePool($resultCache); | |||
| $resultCache = new DoctrineAdapter($resultCache); | |||
There was a problem hiding this comment.
There is a small type mismatch here, since the Symfony adapter takes a CacheProvider instead of a Cache.
alcaeus
force-pushed
the
improvement/psr-6-result-cache
branch
from
a74f03a to
3e30e66
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.