Refactor card.ts and types.ts and add tests
#1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dermotduffy
changed the title
card.ts substantially and add testscard.ts and types.ts and add tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're looking at this PR, it might be because I broke something. Sorry about that. This is a fundamental refactor of the main entry point of the card that had grown beyond maintability and lacked testing. This was slowing development down substantially -- something had to be done! Would appreciate any help in identifying regressions as a result of this PR -- simply by filing issues. With this refactor, I'll be able to make the fixes and add tests, which should mean the issue never arises again. Thank you for your patience.