-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service account example #34
Add service account example #34
Conversation
Please note that I specified version 0.9.4 in the example crate (anticipating the version bump)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dermesser, just my two cents. Please feel free to merge :).
fn publish_stuff(methods: &PubsubMethods, message: &str) { | ||
check_or_create_topic(&methods); | ||
|
||
let message = pubsub::PubsubMessage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this also be the following ?
let message = pubsub::PubsubMessage {
// Base64 encoded!
data: Some(base64::encode(message.as_bytes())),
...Default::default()
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point!
match result { | ||
Err(e) => { | ||
// There's a JSON decode error happening, even on successful returns. :/ | ||
println!("Ack error: {:?}", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, maybe a problem in the code generated by google-apis-rs ? Or already fixed thanks to the empty-structs
PR recently submitted ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the empty-structs
PR has fixed this. Forgot to remove the comment though
I addressed your points. I'll go ahead and use my newly acquired privilege, and merge this PR then :) |
@dermesser Congratulations ! And thank you ! Just a moment ago I used the youtube command-line, not knowing what I was doing at all. The authentication was easy as pie, and the CLI program actually helped me to figure out what kind of information it needed. It's way nicer than I had it in mind, and quite ready for general consumption I believe. Also thanks to you ! |
(I'm still creating PRs so you know what's going on -- otherwise I can just push directly)