Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependencies): use url = 0.5; the bump to 1.0 broke us #24

Merged
merged 1 commit into from
May 20, 2016
Merged

fix(dependencies): use url = 0.5; the bump to 1.0 broke us #24

merged 1 commit into from
May 20, 2016

Conversation

dermesser
Copy link
Owner

Fixes #23.

@dermesser
Copy link
Owner Author

...a proper upgrade to url = 1.0 requires some more work, but this should be a good solution, too.

They changed serialize() to byte_serialize(): http://servo.github.io/rust-url/url/form_urlencoded/fn.byte_serialize.html

@bluss
Copy link

bluss commented Apr 26, 2016

Note to the maintainer: All the open upper bound version requirements in Cargo.toml must be fixed, otherwise your crate will break from new major versions again.

@bluss
Copy link

bluss commented Apr 26, 2016

The fix would be to use something like this:

[dependencies]
chrono = "0.2"
log = "0.3"
mime = "0.1"
url = "0.5"
hyper = "0.8.0"
itertools = "0.4"
...

This way only compatible upgrades from those versions will be used. This is the standard way to use version requirements.

@Byron Byron merged commit 5c4e318 into dermesser:master May 20, 2016
@Byron
Copy link
Collaborator

Byron commented May 20, 2016

Thank you ! I am now spending some time on getting this crate into a fully working state.

@bluss
Copy link

bluss commented Sep 27, 2016

The other deps remain with open ended version ranges, so they can still result in breakage the same way at some point down the line.

@dermesser
Copy link
Owner Author

@bluss, you're right, I've been meaning to do this.

@bluss
Copy link

bluss commented Sep 28, 2016

Great.

Byron pushed a commit that referenced this pull request Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants