Adrienne / Fix reset password getting SSOed #18018
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienne-deriv
requested review from
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
nijil-deriv and
yashim-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adrienne-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
adrienne-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
adrienne-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-fix-create-password-sso.binary.sx/ |
adrienne-deriv
commented
Jan 24, 2025
| const auth_keys = ['acct', 'token']; | ||
| const is_acct_token_params = auth_keys.some( | ||
| account_key => key?.includes(account_key) && key !== 'affiliate_token' | ||
| ); |
There was a problem hiding this comment.
Just check if query parameters has acct or token, then we set logged_state to true
jim-deriv
previously approved these changes
Jan 24, 2025
shayan-deriv
approved these changes
Jan 24, 2025
amam-deriv
previously approved these changes
Jan 24, 2025
prince-deriv
dismissed stale reviews from amam-deriv and jim-deriv
via
c9f0459
amam-deriv
approved these changes
Jan 24, 2025
prince-deriv
added a commit
to prince-deriv/deriv-app
that referenced
this pull request
Jan 24, 2025
* chore: only set logged state cookies when we see acct and token in params --------- Co-authored-by: Prince <[email protected]>
amam-deriv
pushed a commit
that referenced
this pull request
Jan 24, 2025
* chore: only set logged state cookies when we see acct and token in params --------- Co-authored-by: adrienne-deriv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
truewhen user is logging in using social login (Google, Facebook) in order for other apps to be automatically logged inPlease provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.