Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adrienne / Fixed an issue where during onboarding, SSO kicks in #18012

Merged
merged 1 commit into from
Jan 24, 2025
+1 −1
Merged

Adrienne / Fixed an issue where during onboarding, SSO kicks in #18012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/Stores/client-store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2244,7 +2244,7 @@ export default class ClientStore extends BaseStore {
is_social_signup_provider = true;
// NOTE: Remove this logic once social signup is intergated with OIDC
const loggedState = Cookies.get('logged_state');
if (loggedState === 'false') {
if (loggedState === 'false' && !search_params.get('action') === 'signup') {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is part of the action=signup flow, thus logged state is wrongly set to true here
Screenshot 2025-01-22 at 1 56 16 PM

const currentDomain = window.location.hostname.split('.').slice(-2).join('.');
Cookies.set('logged_state', 'true', {
expires: 30,
Expand Down
Loading