Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change redirection for residence #18006

Conversation

lubega-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 20, 2025 9:06am

@habib-deriv habib-deriv merged commit 24fb835 into deriv-com:change-redirection-for-residence Jan 20, 2025
11 of 12 checks passed
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/18006](https://github.com/deriv-com/deriv-app/pull/18006)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-change-redirection-for-r-0c402b.binary.sx?qa_server=red.derivws.com&app_id=32227
    - **Original**: https://deriv-app-git-fork-lubega-deriv-change-redirection-for-r-0c402b.binary.sx
- **App ID**: `32227`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 34
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-change-redirection-for-r-0c402b.binary.sx/

habib-deriv added a commit that referenced this pull request Jan 22, 2025
* [TRAH5324] Suisin/chore: fix to not check citizen and check residence instead (#17986)

* chore: fix to not check citizen and check residence instead

* chore: change hooks to only contain isHubRedirectionEnabled

* fix: check redirection based on authorize country (#18004)

* Change redirection for residence (#18006)

* fix: check redirection based on authorize country

* fix: remove trading_hub

---------

Co-authored-by: Sui Sin <[email protected]>
Co-authored-by: lubega-deriv <[email protected]>
rupato-deriv pushed a commit that referenced this pull request Jan 22, 2025
* [TRAH5324] Suisin/chore: fix to not check citizen and check residence instead (#17986)

* chore: fix to not check citizen and check residence instead

* chore: change hooks to only contain isHubRedirectionEnabled

* fix: check redirection based on authorize country (#18004)

* Change redirection for residence (#18006)

* fix: check redirection based on authorize country

* fix: remove trading_hub

---------

Co-authored-by: Sui Sin <[email protected]>
Co-authored-by: lubega-deriv <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants