-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change redirection for residence #18006
Merged
habib-deriv
merged 2 commits into
deriv-com:change-redirection-for-residence
from
lubega-deriv:change-redirection-for-residence
Jan 20, 2025
Merged
Change redirection for residence #18006
habib-deriv
merged 2 commits into
deriv-com:change-redirection-for-residence
from
lubega-deriv:change-redirection-for-residence
Jan 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubega-deriv
requested review from
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
nijil-deriv,
yashim-deriv,
heorhi-deriv and
jim-deriv
as code owners
January 20, 2025 08:41
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
habib-deriv
approved these changes
Jan 20, 2025
habib-deriv
merged commit Jan 20, 2025
24fb835
into
deriv-com:change-redirection-for-residence
11 of 12 checks passed
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-change-redirection-for-r-0c402b.binary.sx/ |
habib-deriv
added a commit
that referenced
this pull request
Jan 22, 2025
* [TRAH5324] Suisin/chore: fix to not check citizen and check residence instead (#17986) * chore: fix to not check citizen and check residence instead * chore: change hooks to only contain isHubRedirectionEnabled * fix: check redirection based on authorize country (#18004) * Change redirection for residence (#18006) * fix: check redirection based on authorize country * fix: remove trading_hub --------- Co-authored-by: Sui Sin <[email protected]> Co-authored-by: lubega-deriv <[email protected]>
rupato-deriv
pushed a commit
that referenced
this pull request
Jan 22, 2025
* [TRAH5324] Suisin/chore: fix to not check citizen and check residence instead (#17986) * chore: fix to not check citizen and check residence instead * chore: change hooks to only contain isHubRedirectionEnabled * fix: check redirection based on authorize country (#18004) * Change redirection for residence (#18006) * fix: check redirection based on authorize country * fix: remove trading_hub --------- Co-authored-by: Sui Sin <[email protected]> Co-authored-by: lubega-deriv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.