Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nijil / Info content is missing in Carousal component for RTL layout #17934

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

nijil-deriv
Copy link
Contributor

Changes:

Info content is missing in Carousal component for RTL layout

Screenshots:

Before
Screenshot 2025-01-02 at 7 06 54 PM

After
Screenshot 2025-01-02 at 7 07 14 PM

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 3, 2025 7:29am

@coveralls
Copy link

coveralls commented Jan 2, 2025

Pull Request Test Coverage Report for Build 12594112733

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 53.762%

Files with Coverage Reduction New Missed Lines %
packages/trader/src/App/Components/Elements/market-countdown-timer.tsx 1 83.7%
Totals Coverage Status
Change from base Build 12582227830: -0.003%
Covered Lines: 33058
Relevant Lines: 57283

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Jan 2, 2025

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17934](https://github.com/deriv-com/deriv-app/pull/17934)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nijil-deriv-info-arabic-fix.binary.sx?qa_server=red.derivws.com&app_id=24101
    - **Original**: https://deriv-app-git-fork-nijil-deriv-info-arabic-fix.binary.sx
- **App ID**: `24101`

Copy link
Contributor

github-actions bot commented Jan 2, 2025

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-nijil-deriv-info-arabic-fix.binary.sx/

@nijil-deriv nijil-deriv merged commit 0810f3e into deriv-com:master Jan 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants