Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuzhy/TRAH-5083/whatsapp icon missing issue #17904

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

Nuzhy-Deriv
Copy link
Contributor

@Nuzhy-Deriv Nuzhy-Deriv commented Dec 26, 2024

  • update to display whatsapp icon only either livechat or intercom available.

Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 30, 2024 5:54am

@coveralls
Copy link

coveralls commented Dec 26, 2024

Pull Request Test Coverage Report for Build 12542393302

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 220 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+1.7%) to 55.609%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/App/Components/Elements/WhatsApp/whatsapp.tsx 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
packages/trader/src/AppV2/Components/ServiceErrorSheet/service-error-sheet.tsx 2 92.55%
packages/trader/src/AppV2/Containers/Trade/trade.tsx 3 86.96%
packages/core/src/App/Containers/Layout/header/header.tsx 5 56.79%
packages/reports/src/Containers/open-positions.tsx 5 85.02%
packages/core/src/App/Containers/Layout/header/dtrader-header.tsx 6 67.61%
packages/components/src/components/page-overlay/page-overlay.tsx 9 0.0%
packages/trader/src/AppV2/Containers/Trade/trade-types.tsx 10 83.09%
packages/core/src/Stores/common-store.js 63 0.0%
packages/bot-web-ui/src/stores/run-panel-store.ts 117 41.14%
Totals Coverage Status
Change from base Build 12501168312: 1.7%
Covered Lines: 15669
Relevant Lines: 25564

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Dec 26, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17904](https://github.com/deriv-com/deriv-app/pull/17904)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nuzhy-deriv-nuzhy-whatsapp-icon-issue.binary.sx?qa_server=red.derivws.com&app_id=31528
    - **Original**: https://deriv-app-git-fork-nuzhy-deriv-nuzhy-whatsapp-icon-issue.binary.sx
- **App ID**: `31528`

Copy link
Contributor

github-actions bot commented Dec 26, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 39
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-nuzhy-deriv-nuzhy-whatsapp-icon-issue.binary.sx/

matin-deriv
matin-deriv previously approved these changes Dec 26, 2024
@Nuzhy-Deriv Nuzhy-Deriv changed the title Nuzhy/_/whatsapp icon missing issue Nuzhy/TRAH-5083/whatsapp icon missing issue Dec 30, 2024
@jim-deriv jim-deriv merged commit 3576747 into deriv-com:master Jan 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants