-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRAH-5056] Suisin/chore: change app ID based on FF value #17889
Merged
habib-deriv
merged 7 commits into
deriv-com:master
from
suisin-deriv:suisin/TRAH5056/change_app_id_based_on_FF
Jan 6, 2025
Merged
[TRAH-5056] Suisin/chore: change app ID based on FF value #17889
habib-deriv
merged 7 commits into
deriv-com:master
from
suisin-deriv:suisin/TRAH5056/change_app_id_based_on_FF
Jan 6, 2025
+123
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suisin-deriv
requested review from
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
nijil-deriv,
sandeep-deriv and
yashim-deriv
as code owners
December 24, 2024 07:00
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 12594872212Details
💛 - Coveralls |
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-trah5056changeapp-05c295.binary.sx/ |
shontzu-deriv
approved these changes
Dec 24, 2024
aizad-deriv
approved these changes
Dec 24, 2024
habib-deriv
previously approved these changes
Dec 24, 2024
suisin-deriv
force-pushed
the
suisin/TRAH5056/change_app_id_based_on_FF
branch
from
January 3, 2025 07:52
6b79b6b
to
e0f5d9f
Compare
habib-deriv
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
App ID should change to 61554 when
trigger_login_for_hub_country_list
feature flag value is true for certain countriesScreenshots:
Screen.Recording.2024-12-24.at.2.59.33.PM.mov