Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ahmed/DAPI-819/chore--code-improvement" #184

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Revert "ahmed/DAPI-819/chore--code-improvement" #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/components/AccountSwitcher/__tests__/AccountSwitcher.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ mockUseLogout.mockImplementation(() => {
};
});

describe.skip('HeroHeader', () => {
describe('HeroHeader', () => {
beforeEach(() => {
mockUseAuthContext.mockImplementation(() => {
return {
Expand All @@ -64,13 +64,13 @@ describe.skip('HeroHeader', () => {
jest.clearAllMocks();
});

it('Should render current account ', () => {
it.skip('Should render current account ', () => {
const current_account_button = screen.getByRole('button', { name: /CR111111/i });

expect(current_account_button).toBeInTheDocument();
});

it('Should call do logout on logout button click', async () => {
it.skip('Should call do logout on logout button click', async () => {
const current_account_button = await screen.findByRole('button', { name: /CR111111/i });

await act(async () => {
Expand All @@ -86,7 +86,7 @@ describe.skip('HeroHeader', () => {
expect(mockLogout).toHaveBeenCalledTimes(1);
});

it('should be able to close the dropdown by clicking on the arrow', async () => {
it.skip('should be able to close the dropdown by clicking on the arrow', async () => {
const current_account_button = await screen.findByRole('button', { name: /CR111111/i });

await act(async () => {
Expand All @@ -102,7 +102,7 @@ describe.skip('HeroHeader', () => {
expect(close_dropdown_button).not.toBeVisible();
});

it('Should render Accounts when no account is selected', () => {
it.skip('Should render Accounts when no account is selected', () => {
cleanup();
mockUseAuthContext.mockImplementation(() => {
return {
Expand All @@ -127,7 +127,7 @@ describe.skip('HeroHeader', () => {
expect(accounts_button).toBeInTheDocument();
});

it('Should render the dropdown menu on current account button click', async () => {
it.skip('Should render the dropdown menu on current account button click', async () => {
const current_account_button = screen.getByRole('button', { name: /USD/i });

await act(async () => {
Expand All @@ -139,7 +139,7 @@ describe.skip('HeroHeader', () => {
expect(menu_items.length).toBe(1);
});

it('Should update current account on menu item click', async () => {
it.skip('Should update current account on menu item click', async () => {
mockUseAuthContext.mockImplementation(() => {
return {
loginAccounts: fake_accounts,
Expand Down
287 changes: 287 additions & 0 deletions src/components/ApiTokenNavbarItem/__tests__/ApiTokenNavbarItem.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,287 @@
import useApiToken from '@site/src/hooks/useApiToken';
import useAuthContext from '@site/src/hooks/useAuthContext';
import userEvent from '@testing-library/user-event';
import useAppManager from '@site/src/hooks/useAppManager';
import { render, screen } from '@site/src/test-utils';

import React, { act } from 'react';
import ApiTokenNavbarItem from '..';
import { TTokensArrayType } from '@site/src/types';
import { TDashboardTab } from '@site/src/contexts/app-manager/app-manager.context';

jest.mock('@site/src/hooks/useApiToken');
const mockUseApiToken = useApiToken as jest.MockedFunction<
() => Partial<ReturnType<typeof useApiToken>>
>;

jest.mock('@site/src/hooks/useAuthContext');

const mockUseAuthContext = useAuthContext as jest.MockedFunction<
() => Partial<ReturnType<typeof useAuthContext>>
>;

jest.mock('@site/src/hooks/useAppManager');

const mockUseAppManager = useAppManager as jest.MockedFunction<
() => Partial<ReturnType<typeof useAppManager>>
>;

const mockUpdateCurrentTab = jest.fn();

mockUseAppManager.mockImplementation(() => ({
updateCurrentTab: mockUpdateCurrentTab,
}));

describe('Api Token Navbar Item', () => {
it('Should NOT render anything when user is not logged in or is not authenticated', () => {
mockUseAuthContext.mockImplementation(() => ({
is_authorized: false,
is_logged_in: false,
}));

mockUseApiToken.mockImplementation(() => ({
tokens: [],
currentToken: {},
isLoadingTokens: true,
}));

const renderResult = render(<ApiTokenNavbarItem />);
expect(renderResult.container).toBeEmptyDOMElement();
});

it('Should close the token dropdown when clicking outside of it', async () => {
mockUseAuthContext.mockImplementation(() => ({
is_authorized: true,
is_logged_in: true,
}));

mockUseApiToken.mockImplementation(() => ({
tokens: [
{
display_name: 'first_token',
last_used: '',
scopes: ['read', 'trade'],
token: 'token_1',
valid_for_ip: '',
},
{
display_name: 'michio_app_pages',
last_used: '2022-10-04 10:33:51',
scopes: ['read', 'trade', 'payments', 'trading_information', 'admin'],
token: 'token_2',
valid_for_ip: '',
},
],
currentToken: {
display_name: 'first_token',
last_used: '',
scopes: ['read', 'trade'],
token: 'token_1',
valid_for_ip: '',
},
isLoadingTokens: false,
}));

render(<ApiTokenNavbarItem />);

const current_account_button = screen.getByText(/first_token/i);
await act(async () => {
await userEvent.click(current_account_button);
});

const alternative_account = screen.getByText(/michio_app_pages/i);
expect(alternative_account).toBeVisible();

await act(async () => {
await userEvent.click(document.body);
});
expect(alternative_account).not.toBeVisible();
});

it('Should render current api token', async () => {
mockUseAuthContext.mockImplementation(() => ({
is_authorized: true,
is_logged_in: true,
}));

mockUseApiToken.mockImplementation(() => ({
tokens: [
{
display_name: 'first_token',
last_used: '',
scopes: ['read', 'trade'],
token: 'token_1',
valid_for_ip: '',
},
{
display_name: 'michio_app_pages',
last_used: '2022-10-04 10:33:51',
scopes: ['read', 'trade', 'payments', 'trading_information', 'admin'],
token: 'token_2',
valid_for_ip: '',
},
],
currentToken: {
display_name: 'first_token',
last_used: '',
scopes: ['read', 'trade'],
token: 'token_1',
valid_for_ip: '',
},
isLoadingTokens: false,
}));

render(<ApiTokenNavbarItem />);

const currentTokenButton = screen.getByRole('button');

expect(currentTokenButton).toBeInTheDocument();

expect(currentTokenButton).toHaveTextContent('first_token');
});

it('Should render please create token when current token is empty', () => {
mockUseAuthContext.mockImplementation(() => ({
is_authorized: true,
is_logged_in: true,
}));

mockUseApiToken.mockImplementation(() => ({
tokens: [],
currentToken: null,
isLoadingTokens: false,
}));

render(<ApiTokenNavbarItem />);

const currentTokenButton = screen.getByRole('link', { name: /add new token/i });

expect(currentTokenButton).toBeInTheDocument();
});

it.skip('Should update app manager page when clicking on add new token', async () => {
render(<ApiTokenNavbarItem />);

const create_token = await screen.findByText(/add new token/i);

await act(async () => {
await userEvent.click(create_token);
});

expect(mockUpdateCurrentTab).toHaveBeenCalledTimes(1);
expect(mockUpdateCurrentTab).toHaveBeenCalledWith(TDashboardTab.MANAGE_TOKENS);
});

it('Should render token in drop down', async () => {
mockUseAuthContext.mockImplementation(() => ({
is_authorized: true,
is_logged_in: true,
}));

const fake_tokens: TTokensArrayType = [
{
display_name: 'first_token',
last_used: '',
scopes: ['read', 'trade'],
token: 'token_1',
valid_for_ip: '',
},
{
display_name: 'michio_app_pages',
last_used: '2022-10-04 10:33:51',
scopes: ['read', 'trade', 'payments', 'trading_information', 'admin'],
token: 'token_2',
valid_for_ip: '',
},
];

mockUseApiToken.mockImplementation(() => ({
tokens: [...fake_tokens],
currentToken: {
display_name: 'first_token',
last_used: '',
scopes: ['read', 'trade'],
token: 'token_1',
valid_for_ip: '',
},
isLoadingTokens: false,
}));

render(<ApiTokenNavbarItem />);

const current_account_button = screen.getByRole('button');
await act(async () => {
await userEvent.click(current_account_button);
});
const menu_items = screen.getAllByRole('menuitem');
const tokens = menu_items.slice(0, 2);

expect(menu_items.length).toBe(1);

for (const [index, item] of tokens.entries()) {
expect(item).toHaveTextContent(`${fake_tokens[index + 1].display_name}`);
}
});

it('Should update current token on menu item click', async () => {
mockUseAuthContext.mockImplementation(() => ({
is_authorized: true,
is_logged_in: true,
}));

const fake_tokens: TTokensArrayType = [
{
display_name: 'first_token',
last_used: '',
scopes: ['read', 'trade'],
token: 'token_1',
valid_for_ip: '',
},
{
display_name: 'michio_app_pages',
last_used: '2022-10-04 10:33:51',
scopes: ['read', 'trade', 'payments', 'trading_information', 'admin'],
token: 'token_2',
valid_for_ip: '',
},
];

const mockUpdateCurrentToken = jest.fn();

mockUseApiToken.mockImplementation(() => ({
tokens: fake_tokens,
currentToken: {
display_name: 'first_token',
last_used: '',
scopes: ['read', 'trade'],
token: 'token_1',
valid_for_ip: '',
},
isLoadingTokens: false,
updateCurrentToken: mockUpdateCurrentToken,
}));

render(<ApiTokenNavbarItem />);

const currentTokenButton = screen.getByRole('button');
await act(async () => {
await userEvent.click(currentTokenButton);
});

const first_menu_item = screen.getByText(/michio_app_pages/i);

await act(async () => {
await userEvent.click(first_menu_item);
});

expect(mockUpdateCurrentToken).toHaveBeenCalledTimes(1);

expect(mockUpdateCurrentToken).toHaveBeenCalledWith({
display_name: 'michio_app_pages',
last_used: '2022-10-04 10:33:51',
scopes: ['read', 'trade', 'payments', 'trading_information', 'admin'],
token: 'token_2',
valid_for_ip: '',
});
});
});
Loading
Loading