DTRA-2225 / Kate / Update colors #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kate-deriv
commented
Nov 5, 2024
•
kate-deriv
commented
- Updated spot price color, label (paddings, shape) and dot as per Figma
- Updated the color of the Area chart and shadow as per Figma
- Update the color of the Candle&Hollow&OHLC (should have the same color as purchase btn in V2)
- Update the color of Y-axis of the Candle&Hollow&OHLC (should have the same color as candle)
- Add border radius to barrier
- Added colors based on current selected theme
- Passed some new props to HorizontalBarrierStyle (Flutter PR link)
|
Preview Link: https://pr-1641-flutt.smartcharts-preview.pages.dev
|
ahmadtaimoor-deriv
approved these changes
Nov 6, 2024
vinu-deriv
approved these changes
Nov 7, 2024
|
🎉 This PR is included in version 2.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.