[DTRA-V2]Ahmad/Chart Scroll Behavior #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-deriv
reviewed
Oct 28, 2024
kate-deriv
reviewed
Oct 28, 2024
kate-deriv
approved these changes
Oct 28, 2024
|
Preview Link: https://pr-1635-dtra.smartcharts-preview.pages.dev
|
akmal-deriv
approved these changes
Oct 29, 2024
nijil-deriv
approved these changes
Oct 29, 2024
vinu-deriv
approved these changes
Nov 4, 2024
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focus on smoth vertical scroll of the charts in responsive app especially. Now the behavior of chart when scroll should be same as it is any other html element . It should react to the trigger scroll and moving the chart slowing same as html .