Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename binaries in ipyrad/bin dir #6

Closed
isaacovercast opened this issue Nov 10, 2015 · 2 comments
Closed

Rename binaries in ipyrad/bin dir #6

isaacovercast opened this issue Nov 10, 2015 · 2 comments

Comments

@isaacovercast
Copy link
Collaborator

I think it might be better to rename the binaries in the ipyrad/bin dir to 'muscle_osx', 'vsearch_osx', 'smalt_osx', 'samtools_osx', etc..., simplify the naming scheme. We already know we're testing against 32bit arch, and we don't really care about the version, it's just another string to keep track of. There was a bug in the path to the binaries inside the assemble.py file that tripped an assert on macs (bad filename for vsearch). Seems like since we are in control of which binaries are in this directory if we want to update a binary we can copy it in with the the standard simple name we want, this prevents weird file name errors in the future.. just a thought.

@dereneaton
Copy link
Owner

That sounds fine to me. I expect we will not update them very frequently once we settle upon a good working version.

isaacovercast added a commit that referenced this issue Dec 10, 2015
names so we dont' have to change the code if we update a binary.
@isaacovercast
Copy link
Collaborator Author

oof, this got annoying, so i fixed it. I made symlinks inside the bin directory to each of the binaries. Figure it might be useful to retain the binary names that include version number, so i'm making symlinks in the bin directory that have generic names like 'vsearch-linux-x86_64', that point to the originals. Changed code inside core/assembly.py to point to the generic symlinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants