Switch ElementOn back to addEventListener instead of dom.on #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This undoes 7c6d9b9, since using dom.on was causing some undocumented breakages in code relying on on-* listeners firing as a component is being destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undoes 7c6d9b9, since using
dom.onwas causing some undocumented breakages in code relying onon-*listeners firing as a component is being destroyed.Longer-term fix might involve deferring the event listener cleanup, but it's not a huge deal since Derby-rendered HTML elements will usually have no references to them once the containing component is destroyed, anyways.