Add support for breaking <svg> into templates #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
svg
option into templates definition which instructs parser to treat all elements in this template as svg:Currently if you try to break
<svg>
into templates it won't show elements from those templates at all because the information about them being part of<svg>
is lost and it creates them viadocument.createElement()
instead ofdocument.createElementNS()
.So this pull request fixes it. Though I think it should be possible to get rid of the explicit
svg
in template declaration if we modify theElement.prototype.appendTo()
to figure out on execution time whether the element has the<svg>
ancestor or not.