This repository has been archived by the owner on Mar 19, 2021. It is now read-only.
feat: use requestIdleCallback when possible
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch builds on #59 (hat tip to @agreene-coursera!!) and uses `requestIdleCallback` rather than `setTimeout` in environments that support it. If the host environment does not support `requestIdleCallback`, a shim will be used (via [`npmjs.com/requestidlecallback`](https://www.npmjs.com/package/requestidlecallback)). Closes #59.
|
Thanks for picking up/updating the PR! (I've been on vacation and wasn't checking github for a bit) I'm also looking into putting a new PR in axe-core to use a similar script yielding technique as the one outlined in the polyfill you linked to to yield in between rule checks since I've noticed that even with using requestIdleCallback in react-axe individual audit runs can be long enough that they can block/slow down DOM updates. Is that something that y'all would be interested in? |
WilcoFiers
approved these changes
Jan 9, 2019
WilcoFiers
previously requested changes
Jan 9, 2019
* develop: style: setup Prettier and format all code (#62)
WilcoFiers
approved these changes
Jan 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch builds on #59 (hat tip to @agreene-coursera!!) and uses
requestIdleCallbackrather thansetTimeoutin environments that support it. If the host environment does not supportrequestIdleCallback, a shim will be used (vianpmjs.com/requestidlecallback).Closes #59.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)