This repository has been archived by the owner on Mar 19, 2021. It is now read-only.
catch and log errors thrown when calling React.findDOMNode #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly a band-aid so that exceptions thrown when checking a DOM node don't crash a React app. It logs the offending component and error to the console.
Given how the library hooks itself into the component lifecycle, I didn't want to try and remove the use of
findDOMNode
entirely, even though it is deprecated in the newer releases of React/ReactDOM. At a glance, that looks like it will be rather non-trivial to change how react-axe listens for component updates.Closes issue: #74
Reviewer checks
Required fields, to be filled out by PR reviewer(s)