Skip to content
This repository has been archived by the owner on Mar 19, 2021. It is now read-only.

Warnings when used with React.StrictMode #105

Closed
anthonyhastings opened this issue Aug 23, 2019 · 5 comments
Closed

Warnings when used with React.StrictMode #105

anthonyhastings opened this issue Aug 23, 2019 · 5 comments

Comments

@anthonyhastings
Copy link

I'm encountering issues when adding react-axe into a project that has React.StrictMode within it's component tree. The error in particular is:

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Provider which renders StrictMode children. Instead, add a ref directly to the element you want to reference.

Regarding usage of findDOMNode:
https://reactjs.org/docs/strict-mode.html#warning-about-deprecated-finddomnode-usage

I noticed that some preliminary work had begun around this issue in #82 but I didn't see any open issues, and decided to make this one.

@mconiglio
Copy link

Any news on this? We are facing this issue as well

@ticklemepierce
Copy link

ticklemepierce commented Feb 13, 2020

We are also seeing this, though the module seems to be working and logging out a11y violations

@zvebbo
Copy link

zvebbo commented Jul 23, 2020

We also have this problem. As ticklemepierce pointed out, the a11y violations are logged but hey are however drowned out by the findDOMNode warnings.
Any idea on how to solve this?

@arvigeus
Copy link

arvigeus commented Sep 5, 2020

Another bump to this thread

@straker
Copy link
Contributor

straker commented Sep 28, 2020

We have moved this package to be under our axe-core-npm monorepo for easier management. As a result, this repository will be deprecated in the coming weeks.

I have transferred the issue so we can still keep track of it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants