fix(core): Explicitly name the axe module 'axe-core' #859
Conversation
Avoid the "Mismatched anonymous define() modules" error when the axe script is injected in a page that uses requireJS Closes dequelabs#849
|
@noead01 Would it be possible to create an integration test that shows the failure condition that this fix addresses? If that is possible, I would like to see that test added to this PR. |
|
We could just check that the first argument is |
* chore: add Greenkeeper config file * chore(package): update dependencies * chore(package): update dependencies * chore(package): update dependencies * chore(package): update dependencies * chore(package): update dependencies * chore(package): update dependencies * docs(readme): add Greenkeeper badge * chore: update to use babel-core * chore: update to latest uglify config properties `bracketize` became `braces` and `expect` became `reserved`
* chore: rename jest example to help greenkeeper plus signs are invalid in filenames/directories Closes dequelabs#869 * chore: add config to jest_react example Closes dequelabs#865
|
@noead01 Can you add a test that checks that the first argument with which |
Avoid the "Mismatched anonymous define() modules" error when the axe script is injected in a page that uses requireJS Closes dequelabs#849
Added integration test to check the value of the first argument to define() Closes dequelabs#849
|
@WilcoFiers I added the requested changes, but it seems the browser tests failed due to an environmental issue. Is it possible to force a re-build in CircleCI? |
|
@noead01 I triggered the build again, lets see what happens. It was complaining about geckodriver |
|
The flaky test issue in #805 is officially a blocker now. The parallel tests actually fail for me locally as well....but the only error I see is a warning about http2 being an experimental API. That looks related to grunt-contrib-connect and not anything to do with this PR. Edit: I just ran them again and they passed. So it's flaky locally AND in CI. |
Avoid the "Mismatched anonymous define() modules" error when the axe script is injected in a page that uses requireJS
Closes #849
PR Checklist
Please check if your PR fulfills the following requirements:
Description of the changes
Does this PR introduce a breaking change?
Other information