Address vulnerabilities found by retire.js #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 1, 2018 16:26
Removes vulnerability in jshint, fixes lots of mixed spaces and tabs
Removes vulnerability in grunt-legacy-log/lodash
|
Flaky build! ugh. Maybe someone else could try rebuilding this later, it failed for me twice in a row and is completely unrelated to these changes. |
WilcoFiers
approved these changes
Mar 3, 2018
| @@ -1,33 +1,33 @@ | |||
| /*jshint node: true */ | |||
| /*eslint-env node */ | |||
There was a problem hiding this comment.
This file has a bunch of mixed spaces / tabs
| @@ -73,7 +74,7 @@ function convertAttributes (atts) { | |||
| case '|=' : | |||
| regexp = new RegExp('^'+ escapeRegExp(attributeValue) +'(-|$)'); | |||
| break; | |||
| case '=' : | |||
| case '=' : | |||
There was a problem hiding this comment.
That should not be a tab.
| @@ -88,7 +89,7 @@ function convertAttributes (atts) { | |||
| return attributeValue !== value; | |||
| }; | |||
| break; | |||
| default : | |||
| default : | |||
| shadowId: 'a', | ||
| children: [{ | ||
| actualNode: new Vnode('ul'), | ||
| actualNode: new Vnode('li', 'breaking'), |
There was a problem hiding this comment.
Why did this test change?
| assert(false, 'there are no ' + collection); | ||
| return; | ||
| } | ||
| .forEach(function (selector) { |
There was a problem hiding this comment.
You used spaces instead of a tab in this file.
|
Third time's the charm :). I'm merging, since we need this so that other PRs can pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a bunch of work to get our build passing again, including updating to eslint from jshint. There were a lot of mixed spaces and tabs, and I went for tabs because our contributing document says "we prefer tabs over spaces." I used the
polyjuicepackage to convert our jshint config files to eslint. There may still be some redundancies, but I already spent more time on this than I'd like.There are still a few things to do:
hawk,cryptiles,boom,sntpandhoek, which are sub-dependencies of retire.js itself (which we previously added toretireignore.json)