Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [DO NOT MERGE] v4.10.1 diff #4622

Closed
wants to merge 80 commits into from

Conversation

danielweck
Copy link

THIS PR IS FOR TRACKING / CODE DIFF PURPOSES ONLY, DO NOT MERGE.

This PR supersedes #13

NPM package publish:
https://www.npmjs.com/package/@daisy/axe-core-for-ace
https://www.npmjs.com/package/@daisy/axe-core-for-ace/v/4.10.1-canary.1

Tracking of code changes since 4.10.1:
v4.10.1...master
v4.10.1...develop

Axe 4.10.1 official release: https://github.com/dequelabs/axe-core/tree/v4.10.1
...and changelog: https://github.com/dequelabs/axe-core/blob/v4.10.1/CHANGELOG.md

Ace "legacy" patches:

https://github.com/daisy/ace/blob/cf896185ea675b041c64624639b59a5c9179eeb2/packages/ace-core/src/scripts/axe-patch-aria-roles.js#L3-L15

https://github.com/daisy/ace/blob/cf896185ea675b041c64624639b59a5c9179eeb2/packages/ace-core/src/scripts/axe-patch-is-aria-role-allowed.js#L74-L103

https://github.com/daisy/ace/blob/cf896185ea675b041c64624639b59a5c9179eeb2/packages/ace-core/src/scripts/axe-patch-listitem.js#L97-L134

https://github.com/daisy/ace/blob/cf896185ea675b041c64624639b59a5c9179eeb2/packages/ace-core/src/scripts/axe-patch-only-list-items.js#L215-L272

https://github.com/daisy/ace/blob/2eb8d7af5ba3b1e939857b94e39a5b8146ededfd/packages/ace-core/src/scripts/ace-axe.js#L220-L229

https://github.com/daisy/ace/blob/2eb8d7af5ba3b1e939857b94e39a5b8146ededfd/packages/ace-core/src/scripts/ace-axe.js#L93-L176

https://github.com/daisy/ace/blob/2eb8d7af5ba3b1e939857b94e39a5b8146ededfd/packages/ace-core/src/scripts/ace-axe.js#L179-L194

https://github.com/daisy/ace/blob/2eb8d7af5ba3b1e939857b94e39a5b8146ededfd/packages/ace-core/src/scripts/ace-axe.js#L195-L208

https://github.com/daisy/ace/blob/2eb8d7af5ba3b1e939857b94e39a5b8146ededfd/packages/ace-core/src/scripts/ace-axe.js#L209-L215

Useful references:

Ace:

https://github.com/daisy/ace/blob/ace-next/packages/ace-core/src/scripts/ace-axe.js#L94

https://github.com/daisy/ace/blob/ace-next/tests/data/axerule-dpubroles/EPUB/content_001.xhtml#L13-L17

daisy/ace#274 (comment)

daisy/ace#239

daisy/ace#274

W3C:

https://lists.w3.org/Archives/Public/public-publ-wg/2020Sep/0023.html

https://lists.w3.org/Archives/Public/public-epub-wg/2020Sep/0007.html

w3c/dpub-aria#22

w3c/dpub-aria#15

w3c/epub-specs#1316

w3c/html-aria#99

w3c/aria#748

w3c/epubcheck#1018

https://www.w3.org/TR/dpub-aria-1.0/

https://w3c.github.io/dpub-aria/

https://www.w3.org/TR/html-aria/

https://idpf.github.io/epub-guides/epub-aria-authoring/

Axe:

#2759

#1677 (comment)

Daisy-Axe:

https://github.com/daisy/axe-core/blob/v4.10.1_DAISY/test/integration/rules/aria-allowed-role/aria-allowed-role.html#L7-L10

https://github.com/daisy/axe-core/blob/v4.10.1_DAISY/lib/commons/aria/lookup-table.js#L592-L608

https://github.com/daisy/axe-core/blob/v4.10.1_DAISY/lib/checks/aria/aria-required-children-evaluate.js#L12

…xe-patch-listitem scripts/axe-patch-only-list-items)
…ts fail ... the usual colour contrast checks)
…itives for fail/pass/incomplete on my Mac with Chrome)
@danielweck danielweck requested a review from a team as a code owner October 22, 2024 21:12
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@danielweck
Copy link
Author

Apologies, wrong remote :)

@danielweck danielweck closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants