style(lib/core): var -> let and const codemod #4457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romankulkovsf
approved these changes
May 10, 2024
WilcoFiers
reviewed
May 13, 2024
| @@ -7,5 +7,6 @@ doc/api/* | |||
| doc/examples/jest_react/*.js | |||
|
|
|||
| lib/core/imports/*.js | |||
| lib/core/utils/uuid.js | |||
There was a problem hiding this comment.
Did you mean to include this?
There was a problem hiding this comment.
I did @WilcoFiers. It felt weird to update a file that I don't think we wrote (judging by the comment at the top of uuid.js. Eventually when all of these codemods are merged the last PR will turn on the eslint rule no-var and unless we either update this file or ignore it, this file will throw an eslint warning.
There was a problem hiding this comment.
@gaiety-deque Merge conflict, can you update?
WilcoFiers
requested changes
May 13, 2024
wilco and I believe marque is to blame because it is animated
gaiety-deque
changed the base branch from
develop
to
fix-flakey-marque-firefox-test
WilcoFiers
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like #4451 but for
lib/coreThis does add an
.eslintignoreline, perhaps we'd rather skip a file a different way.Smaller part of the full vision: #4444