Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): v4.7.0 #3865

Closed
wants to merge 14 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 85 additions & 39 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,27 +20,56 @@ set_npm_auth: &set_npm_auth

restore_dependency_cache_unix: &restore_dependency_cache_unix
restore_cache:
name: Restore NPM Cache
keys:
- v9-cache-unix-{{ checksum "package-lock.json" }}
- v9-cache-unix-

restore_build: &restore_build
restore_cache:
name: Restore Axe.js Cache
keys:
- v9-cache-build-<< pipeline.git.revision >>

jobs:
# Fetch and cache dependencies.
dependencies_unix:
<<: *defaults
<<: *unix_box
steps:
- browser-tools/install-browser-tools
- checkout
- <<: *set_npm_auth
- <<: *restore_dependency_cache_unix
- run:
name: Skip Install If Cache Exists
command: |
if [ -d "node_modules" ]; then
echo "node_modules exist"
circleci step halt
else
echo "node_modules does not exist"
fi
- browser-tools/install-browser-tools
- <<: *set_npm_auth
- run: npm ci
- run: npx browser-driver-manager install chromedriver --verbose
- save_cache:
key: v9-cache-unix-{{ checksum "package-lock.json" }}
paths:
- node_modules

# Build and cache axe.js
build_unix:
<<: *defaults
<<: *unix_box
steps:
- checkout
- <<: *restore_dependency_cache_unix
- run: npm run build
- save_cache:
key: v9-cache-build-<< pipeline.git.revision >>
paths:
- axe.js
- axe.min.js

# Run ESLINT
lint:
<<: *defaults
Expand All @@ -55,22 +84,22 @@ jobs:
<<: *defaults
<<: *unix_box
steps:
- browser-tools/install-browser-tools
- checkout
- browser-tools/install-browser-tools
- <<: *restore_dependency_cache_unix
- run: npx browser-driver-manager install chromedriver --verbose
- run: npm run build
- <<: *restore_build
- run: npm run test -- --browsers Chrome
- run: npm run test:integration:chrome

test_firefox:
<<: *defaults
<<: *unix_box
steps:
- browser-tools/install-browser-tools
- checkout
- browser-tools/install-browser-tools
- <<: *restore_dependency_cache_unix
- run: npm run build
- <<: *restore_build
- run: npm run test -- --browsers Firefox
- run: npm run test:integration:firefox

Expand All @@ -79,59 +108,59 @@ jobs:
<<: *defaults
<<: *unix_box
steps:
- browser-tools/install-browser-tools
- checkout
- browser-tools/install-browser-tools
- <<: *restore_dependency_cache_unix
- run: npx browser-driver-manager install chromedriver --verbose
- run: npm run build
- <<: *restore_build
- run: npm run test:examples

# Run ACT test cases
test_act:
<<: *defaults
<<: *unix_box
steps:
- browser-tools/install-browser-tools
- checkout
- browser-tools/install-browser-tools
- <<: *restore_dependency_cache_unix
- run: npx browser-driver-manager install chromedriver --verbose
- run: npm run build
- <<: *restore_build
- run: npm run test:act

# Run ARIA practices test cases
test_aria_practices:
<<: *defaults
<<: *unix_box
steps:
- browser-tools/install-browser-tools
- checkout
- browser-tools/install-browser-tools
- <<: *restore_dependency_cache_unix
- run: npx browser-driver-manager install chromedriver --verbose
- run: npm run build
- <<: *restore_build
- run: npm run test:apg

# Test locale files
test_locales:
<<: *defaults
<<: *unix_box
steps:
- browser-tools/install-browser-tools
- checkout
- browser-tools/install-browser-tools
- <<: *restore_dependency_cache_unix
- run: npx browser-driver-manager install chromedriver --verbose
- run: npm run build
- <<: *restore_build
- run: npm run test:locales

# Test virtual rules
test_virtual_rules:
<<: *defaults
<<: *unix_box
steps:
- browser-tools/install-browser-tools
- checkout
- browser-tools/install-browser-tools
- <<: *restore_dependency_cache_unix
- run: npx browser-driver-manager install chromedriver --verbose
- run: npm run build
- <<: *restore_build
- run: npm run test:virtual-rules

# Run the test suite for nightly builds.
Expand All @@ -142,7 +171,7 @@ jobs:
- checkout
- <<: *restore_dependency_cache_unix
- run: sudo apt-get update -y
- run: npm run build
- <<: *restore_build
- run:
name: Install Chrome and ChromeDriver Beta
command: npx browser-driver-manager install chrome=beta chromedriver=beta --verbose
Expand All @@ -169,7 +198,7 @@ jobs:
# also re-installs all repo dependencies as well
- run: npm install w3c/wcag-act-rules#main
- run: npx browser-driver-manager install chromedriver --verbose
- run: npm run build
- <<: *restore_build
- run: npm run test:act

# Run the test suite for nightly builds.
Expand All @@ -185,7 +214,7 @@ jobs:
# also re-installs all repo dependencies as well
- run: npm install w3c/aria-practices#main
- run: npx browser-driver-manager install chromedriver --verbose
- run: npm run build
- <<: *restore_build
- run: npm run test:apg

# Test api docs can be built
Expand Down Expand Up @@ -214,7 +243,7 @@ jobs:
steps:
- checkout
- <<: *restore_dependency_cache_unix
- run: npm run build
- <<: *restore_build
- run: npm run test:node

# Release a "next" version
Expand All @@ -225,21 +254,30 @@ jobs:
- checkout
- <<: *set_npm_auth
- <<: *restore_dependency_cache_unix
- run: npm run build
- <<: *restore_build
- run: npm run next-release
- run: .circleci/verify-release.sh
- run: npm publish --tag=next

# Release a "production" version
release:
verify_sri:
<<: *defaults
<<: *unix_box
steps:
- checkout
- <<: *set_npm_auth
- <<: *restore_dependency_cache_unix
- run: npm run build
- <<: *restore_build
- run: npm run sri-validate

# Release a "production" version
release:
<<: *defaults
<<: *unix_box
steps:
- checkout
- <<: *set_npm_auth
- <<: *restore_dependency_cache_unix
- run: .circleci/verify-release.sh
- run: npm publish

Expand Down Expand Up @@ -282,10 +320,13 @@ workflows:
jobs:
# install deps
- dependencies_unix
- build_unix:
requires:
- dependencies_unix
# Run linting
- lint:
requires:
- dependencies_unix
- build_unix
# Run tests on all commits, but after installing dependencies
- test_chrome:
requires:
Expand Down Expand Up @@ -317,47 +358,52 @@ workflows:
- test_node:
requires:
- test_chrome
# Verify the sri history is correct
- verify_sri:
requires:
- dependencies_unix
filters:
branches:
only:
- /release-*/
- master
# Hold for approval
- hold:
- hold_release:
type: approval
requires:
- test_chrome
- test_firefox
- test_examples
- test_act
- test_aria_practices
- test_locales
- test_virtual_rules
- build_api_docs
- test_rule_help_version
- test_node
- verify_sri
filters:
branches:
only:
- master
# Run a next release on "develop" commits, but only after the tests pass and dependencies are installed
- next_release:
requires:
- dependencies_unix
- test_chrome
- test_firefox
- test_examples
- test_act
- test_aria_practices
- test_locales
- test_virtual_rules
- build_api_docs
- test_rule_help_version
- test_node
filters:
branches:
only: develop
# Run a production release on "master" commits, but only after the tests pass and dependencies are installed
- release:
requires:
- dependencies_unix
- test_chrome
- test_firefox
- test_examples
- test_locales
- test_virtual_rules
- build_api_docs
- test_rule_help_version
- test_node
- hold
- hold_release
filters:
branches:
only: master
Expand Down
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,19 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

## [4.7.0](https://github.com/dequelabs/axe-core/compare/v4.6.2...v4.7.0) (2023-01-20)

### Features

- deprecate color.filteredRectStack, color.getRectStack, and dom.visuallyContains ([#3859](https://github.com/dequelabs/axe-core/issues/3859)) ([3be2bad](https://github.com/dequelabs/axe-core/commit/3be2bad2a896e72a92fe70810500fc1ef67b7027))
- **dom.focusDisabled,dom.isVisibleForScreenreader:** support the inert attribute ([#3857](https://github.com/dequelabs/axe-core/issues/3857)) ([273c971](https://github.com/dequelabs/axe-core/commit/273c97199bd596a288378427becba672b4482678))

### Bug Fixes

- **color-contrast:** correctly compute color contrast of <slot> elements ([#3847](https://github.com/dequelabs/axe-core/issues/3847)) ([4c3a00c](https://github.com/dequelabs/axe-core/commit/4c3a00c7bd6de68b2795be37113a59d804d0a313))
- **link-in-text-block:** allow links with identical colors ([#3861](https://github.com/dequelabs/axe-core/issues/3861)) ([5f90040](https://github.com/dequelabs/axe-core/commit/5f900402470f925686a0d8b41ac01731492bbd30))
- **scrollable-region-focusable:** skip native controls ([#3862](https://github.com/dequelabs/axe-core/issues/3862)) ([b0bdefa](https://github.com/dequelabs/axe-core/commit/b0bdefa34b85363e742ff04e319c014fe95f31f7))

### [4.6.2](https://github.com/dequelabs/axe-core/compare/v4.6.1...v4.6.2) (2022-12-23)

### Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "axe-core",
"version": "4.6.2",
"version": "4.7.0",
"contributors": [
{
"name": "David Sturley",
Expand Down
10 changes: 10 additions & 0 deletions doc/check-options.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
- [region](#region)
- [inline-style-property](#inline-style-property)
- [invalid-children](#invalid-children)
- [link-in-text-block](#link-in-text-block)

## How Checks Work

Expand Down Expand Up @@ -538,3 +539,12 @@ This evaluation method is used in the `list` and `definition-list` rule to deter
| `validNodeNames` | Nodes without role allowed as children |
| `validRoles` | Roles allowed on child elements |
| `divGroups` | Whether the child nodes can be grouped in a div without any role (false by default) |

### link-in-text-block

This evaluation method is used in the `link-in-text-block` rule and tests that either the foreground color or the background color has sufficient contrast between the link text and the surrounding text.

| Option | Default | Description |
| ----------------------- | :------ | :-------------------------------------------------------------------------- |
| `requiredContrastRatio` | `3` | Minimum contrast needed to pass the check between text or background colors |
| `allowSameColor` | `true` | Whether links with colors identical to its surroundings should pass |
1 change: 0 additions & 1 deletion doc/examples/chrome-debugging-protocol/.npmrc

This file was deleted.

6 changes: 3 additions & 3 deletions doc/examples/chrome-debugging-protocol/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"scripts": {
"test": "echo 'No test specified.'"
},
"dependencies": {
"axe-core": "^3.3.1",
"chrome-remote-interface": "^0.27.1"
"devDependencies": {
"axe-core": "^4.6.2",
"chrome-remote-interface": "^0.31.3"
}
}
9 changes: 4 additions & 5 deletions doc/examples/jasmine/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,13 @@
"organization": "Deque Systems, Inc.",
"url": "http://deque.com/"
},
"dependencies": {},
"scripts": {
"test": "karma start karma.conf.js"
},
"devDependencies": {
"axe-core": "^3.3.1",
"karma": "^4.2.0",
"karma-chrome-launcher": "^3.0.0",
"karma-jasmine": "^2.0.1"
"axe-core": "^4.6.2",
"karma": "^6.4.1",
"karma-chrome-launcher": "^3.1.1",
"karma-jasmine": "^5.1.0"
}
}
Loading