refactor: break up context.js and clean it up a bit #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
changed the title
WilcoFiers
commented
Nov 23, 2022
Comment on lines
-185
to
-191
| context.frames.forEach((frame, i) => { | ||
| if (frame.include.length === 0) { | ||
| return new Error( | ||
| 'No elements found for include in Context of frame ' + i | ||
| ); | ||
| } | ||
| }); |
There was a problem hiding this comment.
I left this out because it never worked. We're returning in a forEach. That does nothing. This is completely pointless too. To test the entire frame, include has to be empty. An empty include is a valid option.
straker
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In refactoring the context file I found this bug:
Related to #3793