Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(empty-heading): use virtual node #3582

Merged
merged 27 commits into from
Aug 9, 2022
Merged

refactor(empty-heading): use virtual node #3582

merged 27 commits into from
Aug 9, 2022

Commits on Aug 2, 2022

  1. refactor(empty-heading): use virtual node 

    * use virtual node

references: #3473
    @dbowling
    dbowling committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    48d7e02 View commit details
    Browse the repository at this point in the history

  2. wip - check

    @dbowling
    dbowling committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    0d4b387 View commit details
    Browse the repository at this point in the history

  3. wip

    @dbowling
    dbowling committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    b1285e3 View commit details
    Browse the repository at this point in the history

  4. wip

    @dbowling
    dbowling committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    23b705c View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. wip

    @dbowling
    dbowling committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    e4d58a0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into chore/issue-3473/empty-heading

    @dbowling
    dbowling committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    c98bc15 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into chore/issue-3473/empty-heading

    @dbowling
    dbowling committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    c64ab3c View commit details
    Browse the repository at this point in the history

  4. use virtual node instead of actual

    @dbowling
    dbowling committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    e41211e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'chore/issue-3473/empty-heading' of github.com:dequelabs… 

    …/axe-core into chore/issue-3473/empty-heading
    @dbowling
    dbowling committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    6738d78 View commit details
    Browse the repository at this point in the history

  6. refactor to vnodes

    @dbowling
    dbowling committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    980c002 View commit details
    Browse the repository at this point in the history

  7. heading-matches as virtual node

    @dbowling
    dbowling committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    9b69990 View commit details
    Browse the repository at this point in the history

  8. add virtual rule tests

    @dbowling
    dbowling committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    89a20fe View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. complete jsdoc description

    @dbowling
    dbowling committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    be37d06 View commit details
    Browse the repository at this point in the history

  2. add failing/stubbed out tests

    @dbowling
    dbowling committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    bdc9a2b View commit details
    Browse the repository at this point in the history

  3. pass for title

    @dbowling
    dbowling committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    dd684ff View commit details
    Browse the repository at this point in the history

  4. test for implicit and explicit roles

    @dbowling
    dbowling committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    260ef5d View commit details
    Browse the repository at this point in the history

  5. fix typo

    @dbowling
    dbowling committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    8ad90d0 View commit details
    Browse the repository at this point in the history

  6. remove debug

    @dbowling
    dbowling committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    eb6833a View commit details
    Browse the repository at this point in the history

  7. rm: should fail with no visible text (impossible) 

    Visibility check is not possible, so delete the test
    @dbowling
    dbowling committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    fb449cf View commit details
    Browse the repository at this point in the history

  8. fix aria-label test

    @dbowling
    dbowling committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    44a8499 View commit details
    Browse the repository at this point in the history

  9. fix title test

    @dbowling
    dbowling committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    b645ae6 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. clean up describes

    @dbowling
    dbowling committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    407f850 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into chore/issue-3473/empty-heading

    @dbowling
    dbowling committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    9a17afc View commit details
    Browse the repository at this point in the history

  3. add presentation conflict resolution failing test 

    empty-heading-matches should use getRole() to account for presentation conflict resolution #3482
    @dbowling
    dbowling committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    8463715 View commit details
    Browse the repository at this point in the history

  4. add conflict resolution unit test 

    empty-heading-matches should use getRole() to account for presentation conflict resolution #3482
    @dbowling
    dbowling committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    a30d74b View commit details
    Browse the repository at this point in the history

  5. set children in virtual rule to not incomplete

    @dbowling
    dbowling committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    a2c28e2 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. fix: typo in test

    @dbowling
    dbowling committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    8be5db2 View commit details
    Browse the repository at this point in the history