Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(aria-text): use virtualNode #3581

Merged
merged 17 commits into from
Aug 10, 2022
Merged

Conversation

dbowling
Copy link
Contributor

@dbowling dbowling commented Aug 2, 2022

  • use virtual node

references: #3473

@dbowling dbowling dismissed a stale review via bc940b0 August 8, 2022 03:54
@dbowling dbowling marked this pull request as ready for review August 8, 2022 03:56
@dbowling dbowling requested a review from a team as a code owner August 8, 2022 03:56
test/integration/virtual-rules/aria-text.js Outdated Show resolved Hide resolved
@dbowling dbowling dismissed a stale review via 7c75a6e August 9, 2022 17:40
@dbowling dbowling dismissed WilcoFiers’s stale review August 9, 2022 17:42

Accepted change after adding tabindex

@dbowling dbowling merged commit 70b7f2d into develop Aug 10, 2022
@dbowling dbowling deleted the chore/issue-3473/vnode-aria-text branch August 10, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants