chore: add target assert to queryFixture #3564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulling the anon func out to a var helps the type engine resolve it
These were only used for type specifications
straker
previously requested changes
Jul 27, 2022
Prevented the JSDoc from working on this method.
Suggestion from Steven. This doesn’t appear to show fully in VSCode, but is a more accurate description of code intent.
suggestion from Steven.
adding a #target would be more appropriate rather than trying to save off fixtureSetup which returns the entire virtual node tree
Suggestion from Steve.
Co-authored-by: Steven Lambert <[email protected]>
VS Code does a better job on its own
straker
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axe.testUtils.queryFixture()to guide developers in usage of the fixture helper.