Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs on running tests #3556

Merged
merged 13 commits into from
Jul 25, 2022
Merged

docs: update docs on running tests #3556

merged 13 commits into from
Jul 25, 2022

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 21, 2022

While helping @dbowling and @pschwendy with their prs, I found that we didn't have a lot of docs around how to run and work with the tests. Adding a few readmes to test directories to describe what each one is doing and updating the developer guide docs to include all our testing commands / strategies.

@straker straker requested a review from a team as a code owner July 21, 2022 15:48
doc/developer-guide.md Outdated Show resolved Hide resolved
doc/developer-guide.md Outdated Show resolved Hide resolved

You can also load tests in any supported browser, which is helpful for debugging. Tests require a local server to run, you must first start a local server to serve files. You can use Grunt to start one by running `npm start`. Once your local server is running you can load the following pages in any browser to run tests:
- `npm run test:debug -- testDirs=core`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `npm run test:debug -- testDirs=core`
- `npm run test:debug -- testDirs=core`
You can then open the inspector and debug normally in Chrome by setting breakpoints and refreshing the page. Mocha will re-execute the tests with your debugger running.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this part may not be necessary. Do you feel people debugging tests in a browser wouldn't know this and should to be informed about it?

doc/developer-guide.md Outdated Show resolved Hide resolved
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO rather than spending time documenting this, we should invest time in just making it easier to run/write tests. This is an obvious improvement though, so LGTM

@straker straker merged commit c14cb70 into develop Jul 25, 2022
@straker straker deleted the testing-doc branch July 25, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants