-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update docs on running tests #3556
Conversation
Co-authored-by: Dan Bowling <[email protected]>
|
||
You can also load tests in any supported browser, which is helpful for debugging. Tests require a local server to run, you must first start a local server to serve files. You can use Grunt to start one by running `npm start`. Once your local server is running you can load the following pages in any browser to run tests: | ||
- `npm run test:debug -- testDirs=core` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `npm run test:debug -- testDirs=core` | |
- `npm run test:debug -- testDirs=core` | |
You can then open the inspector and debug normally in Chrome by setting breakpoints and refreshing the page. Mocha will re-execute the tests with your debugger running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this part may not be necessary. Do you feel people debugging tests in a browser wouldn't know this and should to be informed about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO rather than spending time documenting this, we should invest time in just making it easier to run/write tests. This is an obvious improvement though, so LGTM
While helping @dbowling and @pschwendy with their prs, I found that we didn't have a lot of docs around how to run and work with the tests. Adding a few readmes to test directories to describe what each one is doing and updating the developer guide docs to include all our testing commands / strategies.