chore: add locale/_template.json #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanb
reviewed
Jul 12, 2022
| @@ -249,7 +256,7 @@ module.exports = function(grunt) { | |||
| } | |||
| }); | |||
|
|
|||
| grunt.registerTask('translate', ['validate', 'esbuild', 'add-locale']); | |||
| grunt.registerTask('translate', ['validate', 'esbuild', 'add-locale:newLang']); | |||
There was a problem hiding this comment.
Shouldn't we generate this template every time we build?
There was a problem hiding this comment.
That happens here:
https://github.com/dequelabs/axe-core/pull/3536/files#diff-8e7e5f941c67b0cf481a9d650295119d4922b96117e7adc069ba30a81a78c65fR270
Because I added a template prop to add-locale, I need to explicitly call add-locale:newLang, otherwise both commands will run in translate.
dylanb
reviewed
Jul 12, 2022
dylanb
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a template for localisations, this should hopefully make reviewing a little easier.