ci: fix chrome nightly test #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
reviewed
Feb 7, 2022
Co-authored-by: Wilco Fiers <[email protected]>
WilcoFiers
reviewed
Feb 11, 2022
| @@ -117,6 +117,7 @@ | |||
| "act-rules.github.io": "github:act-rules/act-rules.github.io#master", | |||
| "aria-practices": "github:w3c/aria-practices#f7de7ec3a53534018237f24cb9e610f26c30c367", | |||
| "aria-query": "^3.0.0", | |||
| "browser-driver-manager": "1.0.3", | |||
There was a problem hiding this comment.
I audited this version for security.
WilcoFiers
approved these changes
Feb 11, 2022
straker
added a commit
that referenced
this pull request
May 12, 2022
* ci: fix nightly chrome * fix package-lock * fix * npx * test nightly * verbose * fix chrome install * almost there * fix config * Update package.json Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Wilco Fiers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this finally resolves our ChromeDriver being out-of-date and breaking our builds every few months. The package can handle installing Chrome (any channel) and its associated ChromeDriver version, and will default install the version of ChromeDriver that matches the installed Chrome version.
Here's it working on our nightly builds (notice it installs chrome v98 but chromedriver v97 [as 98 doesn't exist for npm] and uses chrome v98 for the test): https://app.circleci.com/pipelines/github/dequelabs/axe-core/3332/workflows/97473ac4-ba89-48c1-81df-85c01a9ae0ec/jobs/40631
Disclaimer: it's my package :)